Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align DKMS package name with RPM spec #567

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cartermckinnon
Copy link

@cartermckinnon cartermckinnon commented Oct 31, 2023

The RPM spec for the kernel module DKMS package uses nvidia-open as the package name, but the dkms.conf in this repository uses nvidia.

If you:

yum install https://developer.download.nvidia.com/compute/cuda/repos/rhel7/x86_64/kmod-nvidia-open-dkms-545.23.06-1.el7.x86_64.rpm

Then you end up with a package in your DKMS tree called nvidia-open because of this: https://github.com/NVIDIA/yum-packaging-dkms-nvidia/blob/b28ed69631673c076b797caeec5fd83c452a6f61/dkms-open-nvidia.spec#L2C9-L2C18

If you mktarball and ldtarball that package, it becomes nvidia.

@aritger
Copy link
Collaborator

aritger commented Oct 31, 2023

Thanks for pointing this out. I'm unsure if the nvidia-open in kmod-nvidia-open-dkms-545.23.06-1.el7.x86_64.rpm is correct. I'll check with the maintainer of that package.

@cartermckinnon
Copy link
Author

FWIW, It's convenient in my case to use nvidia-open, to distinguish it from the closed-source kmod in my DKMS tree.

@cartermckinnon
Copy link
Author

@aritger do you have any update on this? I'd like to get rid of the sed I have to work around this 😄

@aritger
Copy link
Collaborator

aritger commented Jan 13, 2024

Sorry, I didn't get much traction on this before. I've filed NVIDIA internal bug 4360392 for this, though.

@cartermckinnon
Copy link
Author

Sounds good, thanks for looking into it!

@Issacwww
Copy link

Issacwww commented Jun 4, 2024

Hey @aritger, is there any update for this?

@aritger
Copy link
Collaborator

aritger commented Jun 5, 2024

Sorry, we haven't made any progress on this, yet.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants